This repository was archived by the owner on Mar 17, 2025. It is now read-only.

[FirebaseObject] Error message is never reset #390 #391

Merged

samtstern merged 1 commit into FirebaseExtended:master from kptdobe:issues/390

Nov 20, 2018

Contributor

kptdobe commented Nov 20, 2018

PR for #390

Reset the _error property on each getter call
Added corresponding tests
Fixed the existing float test (was comparing int, test was failing with a decimal).


          [FirebaseObject] Error message is never reset FirebaseExtended#390

b4ea882

Contributor

samtstern commented Nov 20, 2018

@kptdobe thanks for this! Looks good to me, and appreciate the extra tests.

samtstern merged commit fb31f8e into FirebaseExtended:master

samtstern mentioned this pull request

[FirebaseObject] Error message is never reset #390

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet