Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables deployment of functions to firebase #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m5kr1pka
Copy link

@m5kr1pka m5kr1pka commented Jan 15, 2022

Changes enables deployment of functions to firebase via channelId flag.

Requirements:

IAM Roles changes needed for firebase service account:

  • Cloud Deploy Service Agent
  • Cloud Functions Admin

and update in firebase.json predeploy script:

"predeploy": [
   "npm --prefix \"$RESOURCE_DIR\" install",
]

Related issues:
#54

@m5kr1pka
Copy link
Author

Any feedback?

@dawidcyron
Copy link

@m5kr1pka big thanks for the solution! I was struggling for half a day trying to figure out why my actions were failing while trying to deploy Cloud Functions.

@m5kr1pka
Copy link
Author

It's probably due to permissions, flags or services needs to be enabled. I had a problem a similar problem, for the first time in project I deployed from local machine using firebase tools for GCloud services be enabled, don't remember which service was a problem at the time.

@aalcott14
Copy link

Are there any plans on merging this?

@m5kr1pka m5kr1pka reopened this May 19, 2023
@jakehockey10
Copy link

@m5kr1pka Have you heard anything on merging this from the team? Thanks for contributing this! Looking forward to working with it!

@m5kr1pka
Copy link
Author

@m5kr1pka Have you heard anything on merging this from the team? Thanks for contributing this! Looking forward to working with it!

Unfortunately not. Try using my version. Maybe the issue is that first deployment - you have to push to firebase manually with firebase-cli for all the on gcloud flags to be set/opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants