fix: harden generate_voiceover param sanitization#7
Open
fancyboi999 wants to merge 2 commits intoFireRedTeam:mainfrom
Open
fix: harden generate_voiceover param sanitization#7fancyboi999 wants to merge 2 commits intoFireRedTeam:mainfrom
fancyboi999 wants to merge 2 commits intoFireRedTeam:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{})enum: [min, max]Why
Recent
range/enumsplit improved schema clarity but left edge cases where invalid model output could break the whole voiceover node. This PR ensures field-level degradation instead of pipeline failure.Validation
python -m py_compile src/open_storyline/nodes/core_nodes/generate_voiceover.pyprocesswith mocked LLM/providerScope