feat: add terminal attach mode and refactor container selection#155
Open
zincognity wants to merge 1 commit intoFinsys:mainfrom
Open
feat: add terminal attach mode and refactor container selection#155zincognity wants to merge 1 commit intoFinsys:mainfrom
zincognity wants to merge 1 commit intoFinsys:mainfrom
Conversation
- Introduced a new mode toggle for terminal operations: 'exec' and 'attach'. - Updated container fetching logic to filter based on the selected mode. - Enhanced container selection to handle both exec and attach modes. - Refactored terminal component to support attach functionality with a new AttachTerminal component. - Improved UI elements for better user experience when switching modes. - Added handling for connection states and terminal commands based on the selected mode.
|
Great Feature! Hope to see it added in future <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I really enjoy using this project, it’s super handy and well put together. While working on my Minecraft server setup, I realized I needed to interact with the console using docker attach, but that wasn’t available yet.
So I added a small change to make that possible. It’s a simple tweak, but I think it’ll be useful for anyone running their server in Docker and wanting quick console access.
Thanks for building such an awesome project—I’m glad I could contribute a little improvement!