-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add proof size check when the VRF proof is empty #765
Conversation
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
5da5ad4
to
3214ef3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 66.58% 66.53% -0.05%
==========================================
Files 285 285
Lines 37919 37917 -2
==========================================
- Hits 25248 25228 -20
- Misses 10871 10882 +11
- Partials 1800 1807 +7
|
ostracon/crypto/ed25519/migration.go Lines 41 to 43 in 898b48c
It looks like empty proofs are admitted intentionally. Would you research this? |
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Please add following contents to description:
|
ostracon/spec/core/data_structures.md Line 56 in ae67c39
And update spec please. |
Signed-off-by: 170210 <j170210@icloud.com>
Description
This PR added an error handle in proof size check when the VRF proof is empty.
Previously, we allowed the proof hash to be 0 in Validateproof because there was no proof required when verifying Genesis block's information. However, since there is no Genesis block, the proof hash should not be zero in general verification.
I tested it with finschia-sdk, and there is no problem when this handling was added.
related #510