Fix dredd test #76
Merged
Fix dredd test #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `max_age` to `max_age_num_blocks` of GenesisResponse in the swagger - Add `max_age_duration` of GenesisResponse in the swagger
- `broadcast_tx_sync` - `broadcast_tx_async` - `broadcast_tx_commit` - `tx_search`
- /block_results - /tx_search - /dump_consensus_state - /consensus_params
torao
approved these changes
May 8, 2020
egonspace
reviewed
May 8, 2020
| body.(map[string]interface{})[lastKey] = value | ||
| } | ||
|
|
||
| func (obj *UnmarshalledArbitraryObject) DeleteProperty(keys ...string) { |
There was a problem hiding this comment.
This seems to doing same thing with RemoveProperty(). Is it right?
There was a problem hiding this comment.
Yes, it's right.
I update the function and didn't remove it.
I'll remove it. Thank you.
egonspace
approved these changes
May 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #73
Description
Fix dredd fail case
Add dredd test to circleCI
The dredd test on the circleCI do next progress.
The contract-test-hook binary should be built ubuntu not alpine golang docker image, because the circleCI system is ubuntu and the binary to be build in alphine golang docker doesn't run in ubuntu. I don't know why. And the binary of Tendermint should be build in the alphine golang docker image. haha. So the binaries were build each environment.
You can see the debug history of circleCI for dredd test in the #75.
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer