Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pathlib version from v1.0.0 to v0.15.0 #662

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Mdaiki0730
Copy link
Member

Description

github.com/chigopher/pathlib@v1.0.0 does not exist, so change the dependency version to the appropriate one.

Closes: #661

@Mdaiki0730 Mdaiki0730 self-assigned this Jul 12, 2023
@Mdaiki0730 Mdaiki0730 added the dependencies Pull requests that update a dependency file label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #662 (f7beb95) into main (5a2453e) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   66.16%   66.08%   -0.08%     
==========================================
  Files         275      275              
  Lines       36930    36930              
==========================================
- Hits        24433    24404      -29     
- Misses      10733    10761      +28     
- Partials     1764     1765       +1     

see 13 files with indirect coverage changes

@tnasu
Copy link
Member

tnasu commented Jul 12, 2023

If pathlib is had a dependency by the mockery, I think using the replace directive in the go.mod for excluding the dependency of mockery.

Here are recent updates of mockery. They may be going to upgrade a lot of things.

@Mdaiki0730
Copy link
Member Author

Does excluding a dependency mean replacing it with a specific version?

@ulbqb
Copy link
Member

ulbqb commented Jul 13, 2023

https://github.com/chigopher/pathlib/tags
I think this fix is better because pathlib@v1.0.0 doesn't exist.

Copy link
Member

@tnasu tnasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mdaiki0730 Yes, it does if mockery has a wrong dependency on pathlib-v1.0.0. But, I've confirmed mockery's dependency. It has an exact dependency now. Then I also don't have any comment.

% go mod graph | grep mockery
github.com/Finschia/ostracon github.com/vektra/mockery/v2@v2.30.17
github.com/vektra/mockery/v2@v2.30.17 github.com/chigopher/pathlib@v0.15.0

@Mdaiki0730 Mdaiki0730 merged commit 482b4d5 into Finschia:main Jul 13, 2023
21 checks passed
@Mdaiki0730 Mdaiki0730 deleted the feature/change-pathlib-version branch July 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.0.0 at github.com/chigopher/pathlib is obsolete.
3 participants