feat: big genesis file #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 66.19% 66.39% +0.19%
==========================================
Files 277 278 +1
Lines 36946 37052 +106
==========================================
+ Hits 24456 24599 +143
+ Misses 10733 10682 -51
- Partials 1757 1771 +14
|
dudong2
added
the
C: enhancement
This reverts commit 100d340.
|
The e2e tests seem to fail all the time. E2e tests often have non-reproducible errors related to asynchronous processing, but this happens a lot, maybe there is still some code that has not been fixed enough. Looking at the error log, it seems that SIGSEGV is happening on validator04 out of the four validators. Is there anything we can do to help? |
dudong2
requested review from
0Tech,
jaeseung-bae,
loin3,
tkxkd0159 and
zemyblue
tnasu
reviewed
Mar 13, 2023
ulbqb
approved these changes
Mar 14, 2023
tnasu
approved these changes
Mar 14, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the genesis.json file based migration progressed, the function to write and load large files to the db was required. The block size of leveldb is limited to 4gb. Therefore, if the genesis.json file exceeds 4gb, a way to divide and save it is needed.
100MBunits and save them in the db as keysgenesisDoc0,genesisDoc1, ...genesisDoc255(here int means byte). When divided into larger units (1GB, ...), the test could not be successed due to ci error, so the size was set at 100MB. Also, since100MB * 255 = 25.5GBin this case, I figured it would be fine in most cases.Closes: #577