Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TODOs in #546 #575

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Fix TODOs in #546 #575

merged 7 commits into from
Mar 7, 2023

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Mar 2, 2023

Description

I left some TODOs in #546 and I fix them. In addition, I checked by comparing with tendermint-v0.34.19 and sorted the imports so that the difference with tendermint-v0.34.19 is minimal.

TODOs:

Correction point of view

When using the following combinations, basically, keep Tendermint and use the oc prefix for Ostracon

Tendermint Ostracon Exist combinations: Tendermint/Ostracon
github.com/tendermint/tendermint/abci/types github.com/line/ostracon/abci/types abci/ocabci
types/octypes
abcitypes/ocabcitypes
github.com/tendermint/tendermint/proto/tendermint/blockchain github.com/line/ostracon/proto/ostracon/blockchain bcproto/ocbcproto
github.com/tendermint/tendermint/proto/tendermint/privval github.com/line/ostracon/proto/ostracon/privval privvalproto/ocprivvalproto

Remarks

  • If using its Ostracon only, it uses its Tendermint
    • ex. abci, privvalproto

@tnasu tnasu requested review from Kynea0b and torao as code owners March 2, 2023 05:36
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #575 (ea14407) into main (6be90a9) will increase coverage by 0.04%.
The diff coverage is 28.00%.

❗ Current head ea14407 differs from pull request most recent head ad96844. Consider uploading reports for the commit ad96844 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   66.07%   66.12%   +0.04%     
==========================================
  Files         277      277              
  Lines       36946    36946              
==========================================
+ Hits        24413    24430      +17     
+ Misses      10773    10761      -12     
+ Partials     1760     1755       -5     
Impacted Files Coverage Δ
state/indexer/block/kv/util.go 80.32% <ø> (ø)
state/indexer/sink/psql/psql.go 71.72% <ø> (ø)
blockchain/msgs.go 22.97% <18.18%> (ø)
privval/signer_endpoint.go 76.92% <100.00%> (ø)
privval/signer_server.go 89.28% <100.00%> (ø)
consensus/reactor.go 74.80% <0.00%> (-0.45%) ⬇️
consensus/state.go 72.34% <0.00%> (-0.30%) ⬇️
light/client.go 73.09% <0.00%> (+0.44%) ⬆️
p2p/conn/connection.go 80.38% <0.00%> (+0.57%) ⬆️
p2p/switch.go 66.52% <0.00%> (+0.61%) ⬆️
... and 4 more

@tnasu tnasu marked this pull request as draft March 2, 2023 06:15
@tnasu tnasu self-assigned this Mar 6, 2023
@tnasu tnasu marked this pull request as ready for review March 6, 2023 10:59
@Kynea0b Kynea0b requested a review from ulbqb March 7, 2023 05:42
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Mar 7, 2023
@tnasu tnasu merged commit b77283b into Finschia:main Mar 7, 2023
@tnasu tnasu deleted the main-minors branch April 14, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants