Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of paremeters in require.Equalf() #534

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

torao
Copy link
Contributor

@torao torao commented Dec 16, 2022

Description

In a few code the parameters passed to require.Equalf() and require.Equal() are actual, expected in that order, but they should be expected, actual.

Closes: #XXX

@torao torao added the C: bug Classification: Something isn't working label Dec 16, 2022
@torao torao requested a review from Kynea0b as a code owner December 16, 2022 01:59
@torao torao self-assigned this Dec 16, 2022
@torao torao requested a review from tnasu as a code owner December 16, 2022 01:59
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #534 (0a018dc) into main (e8f0b19) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   66.03%   66.09%   +0.06%     
==========================================
  Files         279      279              
  Lines       38045    38068      +23     
==========================================
+ Hits        25122    25162      +40     
+ Misses      11123    11107      -16     
+ Partials     1800     1799       -1     
Impacted Files Coverage Δ
crypto/ed25519/ed25519.go 45.12% <0.00%> (-1.22%) ⬇️
consensus/reactor.go 74.66% <0.00%> (-0.45%) ⬇️
mempool/reactor.go 78.57% <0.00%> (ø)
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
crypto/vrf/vrf_r2ishiguro.go
crypto/vrf/vrf_libsodium.go 78.57% <0.00%> (ø)
p2p/conn/connection.go 80.38% <0.00%> (+0.57%) ⬆️
consensus/state.go 73.99% <0.00%> (+0.58%) ⬆️
blockchain/v0/pool.go 82.94% <0.00%> (+4.13%) ⬆️
crypto/sr25519/pubkey.go 43.58% <0.00%> (+7.69%) ⬆️

@ulbqb ulbqb self-requested a review December 16, 2022 04:10
@ulbqb ulbqb merged commit 4a4d6f5 into Finschia:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants