Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return postCheck error to abci client #507

Merged
merged 15 commits into from
Nov 25, 2022
Merged

fix: return postCheck error to abci client #507

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
97483ee
Update abci type.proto
ulbqb Nov 21, 2022
0e6e909
Generate stub files
ulbqb Nov 21, 2022
f41f0e5
Revive `postCheck` in only `resCbRecheck`
ulbqb Nov 22, 2022
d7d7f51
Add postCheck error to response
ulbqb Nov 22, 2022
24c97c8
Add tests
ulbqb Nov 24, 2022
39aabac
fix test
ulbqb Nov 24, 2022
343c172
Revert "fix test"
ulbqb Nov 24, 2022
6913c01
Add PostCheckMaxGas tests
ulbqb Nov 24, 2022
5ea342a
Remove meaningless checking
ulbqb Nov 24, 2022
ba1748a
Fix comments
ulbqb Nov 24, 2022
ae29951
Refactoring
ulbqb Nov 24, 2022
eabac26
Add comments
ulbqb Nov 24, 2022
75bdb34
Remove panic
ulbqb Nov 25, 2022
af6a508
Fix redundant code
ulbqb Nov 25, 2022
953c00c
Fix
ulbqb Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@ulbqb
ulbqb committed Nov 24, 2022
commit 39aabacb42f55613c56282605d4a6ff42f362ce6
20 changes: 14 additions & 6 deletions mempool/clist_mempool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,23 +159,31 @@ func TestMempoolFilters(t *testing.T) {
emptyTxArr := []types.Tx{[]byte{}}

nopPreFilter := func(tx types.Tx) error { return nil }
nopPostFilter := func(tx types.Tx, res *abci.ResponseCheckTx) error { return nil }

// each table driven test creates numTxsToCreate txs with checkTx, and at the end clears all remaining txs.
// each tx has 20 bytes
tests := []struct {
numTxsToCreate int
preFilter PreCheckFunc
postFilter PostCheckFunc
expectedNumTxs int
}{
{10, nopPreFilter, 10},
{10, PreCheckMaxBytes(10), 0},
{10, PreCheckMaxBytes(20), 0},
{10, PreCheckMaxBytes(22), 10},
{10, PreCheckMaxBytes(30), 10},
{10, nopPreFilter, nopPostFilter, 10},
{10, PreCheckMaxBytes(10), nopPostFilter, 0},
{10, PreCheckMaxBytes(22), nopPostFilter, 10},
{10, nopPreFilter, PostCheckMaxGas(-1), 10},
{10, nopPreFilter, PostCheckMaxGas(0), 10},
{10, nopPreFilter, PostCheckMaxGas(1), 10},
{10, nopPreFilter, PostCheckMaxGas(3000), 10},
{10, PreCheckMaxBytes(10), PostCheckMaxGas(20), 0},
{10, PreCheckMaxBytes(30), PostCheckMaxGas(20), 10},
{10, PreCheckMaxBytes(22), PostCheckMaxGas(1), 10},
{10, PreCheckMaxBytes(22), PostCheckMaxGas(0), 10},
}
for tcIndex, tt := range tests {
err := mempool.Update(newTestBlock(1, emptyTxArr),
abciResponses(len(emptyTxArr), abci.CodeTypeOK), tt.preFilter, nil)
abciResponses(len(emptyTxArr), abci.CodeTypeOK), tt.preFilter, tt.postFilter)
require.NoError(t, err)
checkTxs(t, mempool, tt.numTxsToCreate, UnknownPeerID)
require.Equal(t, tt.expectedNumTxs, mempool.Size(), "mempool had the incorrect size, on test case %d", tcIndex)
Expand Down