Fix so that HTTP request don't wait for responses indefinitely #506
+95
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there are a few codes that use the golang
http.Client
with no timeout in Ostracon. This can cause stability and safety problems for nodes, as they behave as that they are waiting indefinitely when the destination doesn't respond.This PR replaces HTTP requests naively used without timeouts with those with timeouts. However, this is only for code related to
http.Client{}
or relatedhttp.Get()
, and doesn't consider other TCP or Unix communications.This fix sets the timeout as follows:
The only places affected other than the test code are the CLI commands UPnP prove→discover and dump.