Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the dead links #491

Merged
merged 4 commits into from
Nov 14, 2022
Merged

fix: Update the dead links #491

merged 4 commits into from
Nov 14, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Nov 9, 2022

@tnasu tnasu self-assigned this Nov 9, 2022
@tnasu tnasu added the C: documentation Classification: Improvements or additions to documentation label Nov 9, 2022
@tnasu tnasu marked this pull request as ready for review November 9, 2022 03:54
torao
torao previously approved these changes Nov 9, 2022
@ulbqb ulbqb self-requested a review November 9, 2022 06:25
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #491 (65eeb6e) into main (955cfde) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 65eeb6e differs from pull request most recent head 5bf6b3b. Consider uploading reports for the commit 5bf6b3b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   65.56%   65.45%   -0.12%     
==========================================
  Files         278      278              
  Lines       37927    37927              
==========================================
- Hits        24867    24824      -43     
- Misses      11251    11296      +45     
+ Partials     1809     1807       -2     
Impacted Files Coverage Δ
blockchain/v0/pool.go 79.58% <0.00%> (-4.91%) ⬇️
types/tx.go 90.24% <0.00%> (-3.66%) ⬇️
p2p/pex/pex_reactor.go 79.67% <0.00%> (-1.85%) ⬇️
p2p/switch.go 65.08% <0.00%> (-1.45%) ⬇️
consensus/reactor.go 74.93% <0.00%> (-1.42%) ⬇️
consensus/msgs.go 84.19% <0.00%> (-0.92%) ⬇️
blockchain/v0/reactor.go 69.49% <0.00%> (-0.68%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
consensus/state.go 73.61% <0.00%> (+0.29%) ⬆️
light/client.go 62.05% <0.00%> (+0.44%) ⬆️
... and 3 more

@tnasu
Copy link
Member Author

tnasu commented Nov 9, 2022

This link also seem to be dead. Correct link is https://github.com/line/ostracon/blob/main/docs/en/04-signature-aggregation.md

Thanks! Copied. 1d31b8f

And these equations have error. Error is "Erroneous nesting of equation structures".

This is a bug!? We may be able to fix to separate math of the markdown block. I'll try.
mathjax/MathJax#1892

@tnasu
Copy link
Member Author

tnasu commented Nov 9, 2022

@ulbqb @torao

And these equations have error. Error is "Erroneous nesting of equation structures".

I addressed the mathematical-expressions. But, I left the image of the formula in static directory for the backup.

@tnasu tnasu requested a review from torao November 9, 2022 10:45
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mdaiki0730 Mdaiki0730 self-requested a review November 11, 2022 08:35
@tnasu tnasu merged commit a00b7c1 into Finschia:main Nov 14, 2022
@tnasu tnasu deleted the main-fix-deadlinks branch November 25, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: documentation Classification: Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants