Fix panic when a node stops while processing async network events #466
+866
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torao
changed the title
torao
force-pushed
the
fix/leveldb-close-error
branch
from
498f53d
to
0bd7259
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
- Coverage 65.46% 65.40% -0.06%
==========================================
Files 278 279 +1
Lines 37952 38107 +155
==========================================
+ Hits 24844 24923 +79
- Misses 11295 11361 +66
- Partials 1813 1823 +10
|
torao
force-pushed
the
fix/leveldb-close-error
branch
2 times, most recently
from
db776b3
to
74c48a9
Compare
torao
force-pushed
the
fix/leveldb-close-error
branch
from
74c48a9
to
e4f2e9c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Issue Finschia/finschia-sdk#653.
In threads (go routines) that Reactor lanches ad-hoc, return an error instead of
panic()when loading data from theBlockStore. Also, whenstore.BlockStorereports leveldb close as an error, it'll exit without doing anything if the calling Reactor has already stopped. The currentLoadXxx()functions are not designed to return an error, so the scope of the fix is slightly larger.This fix returns the error if the caller method using the
BlockStoreis capable of returning the error. Note, however, otherwise it willpanic()as it does now.