Fix panic when a node stops while processing async network events #466
+866
−245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Issue Finschia/finschia-sdk#653.
In threads (go routines) that Reactor lanches ad-hoc, return an error instead of
panic()
when loading data from theBlockStore
. Also, whenstore.BlockStore
reports leveldb close as an error, it'll exit without doing anything if the calling Reactor has already stopped. The currentLoadXxx()
functions are not designed to return an error, so the scope of the fix is slightly larger.This fix returns the error if the caller method using the
BlockStore
is capable of returning the error. Note, however, otherwise it willpanic()
as it does now.