Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the thread-unsafe of PeerState logging #458

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Fix the thread-unsafe of PeerState logging #458

merged 2 commits into from
Sep 2, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Sep 2, 2022

Description

I think it seems that PeerState logging is not thread-unsafe. I removed it.

I'm also asking tendermint.

Relates: #457

@tnasu tnasu self-assigned this Sep 2, 2022
@tnasu tnasu marked this pull request as ready for review September 2, 2022 04:46
Kynea0b
Kynea0b previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torao
torao suggested changes Sep 2, 2022
View reviewed changes
consensus/reactor.go Show resolved Hide resolved
torao
torao approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #458 (ac9ad52) into main (619efb2) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   65.50%   65.43%   -0.08%     
==========================================
  Files         278      278              
  Lines       37920    37924       +4     
==========================================
- Hits        24838    24814      -24     
- Misses      11269    11296      +27     
- Partials     1813     1814       +1
Impacted Files Coverage Δ
consensus/reactor.go 75.11% <100.00%> (+0.35%) ⬆️
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
libs/clist/clist.go 68.03% <0.00%> (-3.69%) ⬇️
types/tx.go 90.24% <0.00%> (-3.66%) ⬇️
blockchain/v0/pool.go 78.81% <0.00%> (-3.62%) ⬇️
consensus/state.go 73.09% <0.00%> (-0.24%) ⬇️
p2p/pex/pex_reactor.go 79.67% <0.00%> (ø)
statesync/syncer.go 82.80% <0.00%> (+0.57%) ⬆️

@tnasu tnasu merged commit 38e64c8 into Finschia:main Sep 2, 2022
@zemyblue zemyblue mentioned this pull request Sep 2, 2022
Closed
5 tasks
zemyblue pushed a commit to zemyblue/ostracon that referenced this pull request Sep 2, 2022
@tnasu @zemyblue
Fix the thread-unsafe of PeerState logging (Finschia#458)
c90fbc4 
* Fix the thread-unsafe of PeerState logging

* Add the modification information

(cherry picked from commit 38e64c8)
tnasu added a commit that referenced this pull request Sep 2, 2022
@tnasu
Fix the thread-unsafe of PeerState logging (#458)
8bacec6 
* Fix the thread-unsafe of PeerState logging

* Add the modification information
@zemyblue zemyblue mentioned this pull request Sep 2, 2022
Closed
3 tasks
@tnasu tnasu added the C: bug Classification: Something isn't working label Sep 5, 2022
@tnasu tnasu deleted the main-fix-peerstate branch September 7, 2022 01:39
@tnasu tnasu mentioned this pull request Sep 7, 2022
Closed
@0Tech 0Tech mentioned this pull request Nov 1, 2023
Open
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
C: bug Classification: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b