Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused configuration files #432

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Jun 16, 2022

Description

The following is not used well in this repo. Considering the maintenance cost, it removes at this time.

  • goreleaser
  • mergify
  • .vscode
  • Vagrant

@tnasu tnasu requested review from Kynea0b and torao as code owners June 16, 2022 08:22
@tnasu tnasu self-assigned this Jun 16, 2022
@torao
Copy link
Contributor

torao commented Jun 16, 2022

A Vagrantfile item exists in .dockerignore, should we delete or leave it?

@tnasu
Copy link
Member Author

tnasu commented Jun 16, 2022

A Vagrantfile item exists in .dockerignore, should we delete or leave it?

What's your opinion...?

I think it's enough to leave it for Docker since I cannot imagine using Vargrant on the Docker container.

@torao
Copy link
Contributor

torao commented Jun 16, 2022

Oh, sorry, I mistook it for a .dockerignore file from another repository.

@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jun 17, 2022
@tnasu tnasu merged commit 45b780a into Finschia:main Jun 17, 2022
@tnasu tnasu deleted the main-cleanup branch June 20, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants