Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bls-eth-go-binary version update for apple M1 chip #428

Merged
merged 2 commits into from
Jun 14, 2022
Merged

bls-eth-go-binary version update for apple M1 chip #428

merged 2 commits into from
Jun 14, 2022

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Jun 7, 2022

Description

This PR supports apple M1 chip to local standalone

This PR contains the following changes

  • update herumi/bls-eth-go-binary in go.mod

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #428 (a186a54) into main (f19316f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   65.28%   65.32%   +0.03%     
==========================================
  Files         277      277              
  Lines       37842    37870      +28     
==========================================
+ Hits        24707    24737      +30     
- Misses      11321    11322       +1     
+ Partials     1814     1811       -3     
Impacted Files Coverage Δ
statesync/snapshots.go 93.71% <0.00%> (-1.26%) ⬇️
crypto/ed25519/ed25519.go 45.12% <0.00%> (-1.22%) ⬇️
mempool/reactor.go 78.57% <0.00%> (-1.10%) ⬇️
consensus/reactor.go 74.31% <0.00%> (-0.63%) ⬇️
p2p/conn/connection.go 79.80% <0.00%> (-0.58%) ⬇️
crypto/vrf/vrf_r2ishiguro.go
crypto/vrf/vrf_libsodium.go 78.57% <0.00%> (ø)
consensus/state.go 74.02% <0.00%> (+0.34%) ⬆️
blockchain/v0/pool.go 79.58% <0.00%> (+0.51%) ⬆️
p2p/pex/pex_reactor.go 79.67% <0.00%> (+0.61%) ⬆️
... and 3 more

@da1suk8 da1suk8 marked this pull request as draft June 7, 2022 09:44
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022

CLA assistant check
All committers have signed the CLA.

@Kynea0b Kynea0b added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Jun 7, 2022
@torao
Copy link
Contributor

torao commented Jun 8, 2022

@kokeshiM0chi Could you review the CI failures and provide appropriate guidance to the submitter?

@da1suk8 da1suk8 marked this pull request as ready for review June 14, 2022 01:13
@da1suk8 da1suk8 merged commit e974b31 into Finschia:main Jun 14, 2022
@da1suk8 da1suk8 deleted the fix/bls_update branch June 14, 2022 03:32
@tnasu tnasu mentioned this pull request Jun 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants