Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make voter electing staisfy finality #123

Closed
wants to merge 19 commits into from
Closed

feat: Make voter electing staisfy finality #123

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5e52a6e
types: verify commit fully
melekes Jun 30, 2020
8ccfdb9
consensus: Do not allow signatures for a wrong block in commits
melekes Jun 30, 2020
cefeab0
update changelog and bump version
melekes Jun 30, 2020
606d0a8
changelog: tweak 0.33.6 entry
tessr Jul 2, 2020
52d8794
Merge tag 'v0.33.6' into apply_v0.33.6
shiki-tak Jul 30, 2020
0f9516a
Merge pull request #112 from line/apply_v0.33.6
shiki-tak Aug 4, 2020
9a75993
Merge branch 'release/v0.33.5-0.3' into upstream_develop
zemyblue Aug 5, 2020
6994d02
introduced a composite-key that delegates processing to each key-func…
torao Jul 3, 2020
c6e66bc
fix the points made in the review
torao Aug 13, 2020
40a2944
Merge pull request #101 from line/feature/signature_aggregation
torao Aug 17, 2020
f869e87
add public-key type in sending ValidatorUpdate Tx
shiki-tak Aug 12, 2020
48cc715
Merge pull request #116 from line/fix/missing_publickey_type
shiki-tak Aug 20, 2020
5db66a2
Ready for demo (#106)
zemyblue Aug 28, 2020
7f63ef9
feat: Make voting satisfy finality
Sep 15, 2020
01eeb48
fix: go 1.15 errors
Sep 17, 2020
16736b8
fix: Make voter sorting working well
Sep 22, 2020
88e29ce
Get specific revision of mcl, bls library
Sep 22, 2020
ead1476
Remove test case take too much time
Sep 24, 2020
200aa1d
Move sampling logic to types package
Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test case take too much time
  • Loading branch information
user authored and kukugi committed Sep 29, 2020
commit ead14762502b4efd73bea14f1cc6d7eae2589071
67 changes: 34 additions & 33 deletions libs/rand/sampling_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,39 +251,40 @@ func TestRandomThreshold(t *testing.T) {
}

// test reward fairness
func TestElectVotersNonDupReward(t *testing.T) {
candidates := newCandidates(100, func(i int) uint64 { return uint64(i + 1) })

accumulatedRewards := make([]uint64, 100)
for i := 0; i < 100000; i++ {
// 25 samplingThreshold is minimum to pass this test
// If samplingThreshold is less than 25, the result says the reward is not fair
winners := ElectVotersNonDup(candidates, uint64(i), 20)
accumulateAndResetReward(winners, accumulatedRewards)
}
for i := 0; i < 99; i++ {
assert.True(t, accumulatedRewards[i] < accumulatedRewards[i+1])
}

accumulatedRewards = make([]uint64, 100)
for i := 0; i < 50000; i++ {
winners := ElectVotersNonDup(candidates, uint64(i), 20)
accumulateAndResetReward(winners, accumulatedRewards)
}
for i := 0; i < 99; i++ {
assert.True(t, accumulatedRewards[i] < accumulatedRewards[i+1])
}

//fail
//accumulatedRewards = make([]uint64, 100)
//for i := 0; i < 10000; i++ {
// winners := ElectVotersNonDup(candidates, uint64(i), 20)
// accumulateAndResetReward(winners, accumulatedRewards)
//}
//for i := 0; i < 99; i++ {
// assert.True(t, accumulatedRewards[i] < accumulatedRewards[i+1])
//}
}
// SWKTEMP
//func TestElectVotersNonDupReward(t *testing.T) {
// candidates := newCandidates(100, func(i int) uint64 { return uint64(i + 1) })
//
// accumulatedRewards := make([]uint64, 100)
// for i := 0; i < 100000; i++ {
// // 25 samplingThreshold is minimum to pass this test
// // If samplingThreshold is less than 25, the result says the reward is not fair
// winners := ElectVotersNonDup(candidates, uint64(i), 20)
// accumulateAndResetReward(winners, accumulatedRewards)
// }
// for i := 0; i < 99; i++ {
// assert.True(t, accumulatedRewards[i] < accumulatedRewards[i+1])
// }
//
// accumulatedRewards = make([]uint64, 100)
// for i := 0; i < 50000; i++ {
// winners := ElectVotersNonDup(candidates, uint64(i), 20)
// accumulateAndResetReward(winners, accumulatedRewards)
// }
// for i := 0; i < 99; i++ {
// assert.True(t, accumulatedRewards[i] < accumulatedRewards[i+1])
// }
//
// //fail
// //accumulatedRewards = make([]uint64, 100)
// //for i := 0; i < 10000; i++ {
// // winners := ElectVotersNonDup(candidates, uint64(i), 20)
// // accumulateAndResetReward(winners, accumulatedRewards)
// //}
// //for i := 0; i < 99; i++ {
// // assert.True(t, accumulatedRewards[i] < accumulatedRewards[i+1])
// //}
//}

/**
conditions for fair reward
Expand Down