feat: Implement CallCallablePoint Function to wasm Keeper
#948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kynea0b
changed the title
Kynea0b
changed the title
CallCallablePoint Function
Kynea0b
changed the title
CallCallablePoint FunctionCallCallablePoint Function
Kynea0b
changed the title
CallCallablePoint FunctionCallCallablePoint Function to wasm Keeper
Kynea0b
force-pushed
the
issue-CallCallablePointFun
branch
from
501660a
to
49c49ed
Compare
…ilsByQuery The test case is `TestDynamicCallWithWriteFailsByQuery`. This expected error message is changed by this https://github.com/line/wasmvm/pull/93/files#diff-9b2b2a113d3afdc3b2344ae2f20a48fb7920f793726c218700f3108ebdc79252R454.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dynamic_link #948 +/- ##
==============================================
Coverage 61.08% 61.09%
==============================================
Files 873 873
Lines 98602 98710 +108
==============================================
+ Hits 60231 60306 +75
- Misses 34767 34795 +28
- Partials 3604 3609 +5
|
Kynea0b
force-pushed
the
issue-CallCallablePointFun
branch
from
8ffef0d
to
b40ec63
Compare
da1suk8
reviewed
Apr 6, 2023
da1suk8
reviewed
Apr 6, 2023
In keeper.go both Execute and Query call vm.CallCallablePoint(). For this reason, it is now possible to distinguish whether vm.CallCallablePoint() is called with isReadOnly=false or true with the name of the upper function that wraps the vm function.
This is an omission of the previous commit
|
Closing this PR as it will be moved to wasmd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of this issue.
Finschia/cosmwasm#252
This pr uses vm.CallCallablePoint fun of the wasmvm pr. So this updated after it is merged.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(This PR does not change the API)