Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename x/collection events #639

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 10, 2022

Description

The x/collection events now use the past tense.
Also renamed EventAbandon into EventRenounced since the latter is already in use on other implementations.

Motivation and context

To unify the event nomenclature of x/collection.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #639 (cdb5b42) into main (400203d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   60.22%   60.22%           
=======================================
  Files         817      817           
  Lines       94989    94989           
=======================================
+ Hits        57205    57210    +5     
+ Misses      34315    34310    -5     
  Partials     3469     3469           
Impacted Files Coverage Δ
x/collection/event.go 100.00% <100.00%> (ø)
x/collection/keeper/msg_server.go 74.57% <100.00%> (ø)
x/collection/keeper/supply.go 89.11% <100.00%> (ø)
x/token/validation.go 69.09% <0.00%> (-18.19%) ⬇️
x/token/msgs.go 26.39% <0.00%> (-10.16%) ⬇️
x/foundation/msgs.go 37.98% <0.00%> (-3.37%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/foundation/foundation.go 75.81% <0.00%> (+2.16%) ⬆️
x/collection/msgs.go 42.22% <0.00%> (+6.11%) ⬆️
x/foundation/authz.go 100.00% <0.00%> (+20.00%) ⬆️

@0Tech 0Tech requested review from dudong2 and zemyblue August 10, 2022 04:58
@0Tech 0Tech marked this pull request as ready for review August 10, 2022 04:58
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check swagger file

x/collection/event.go Outdated Show resolved Hide resolved
x/collection/event.go Outdated Show resolved Hide resolved
x/collection/event.go Outdated Show resolved Hide resolved
x/collection/event.go Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit 56799e7 into Finschia:main Aug 16, 2022
@0Tech 0Tech deleted the collection_rename branch August 16, 2022 03:02
zemyblue added a commit that referenced this pull request Sep 5, 2022
* main:
  fix: wasm module's FIXME in the snapshotter.go file (#649)
  chore(deps): Bump actions/setup-go from 3.2.1 to 3.3.0 (#650)
  chore(deps): Bump actions/cache from 3.0.7 to 3.0.8 (#648)
  fix: remove legacy codes of wasm (#640)
  chore(deps): Bump github.com/mattn/go-isatty from 0.0.14 to 0.0.16 (#643)
  chore(deps): Bump actions/cache from 3.0.6 to 3.0.7 (#642)
  chore: change some minor things that haven't been fixed in #549 (#635)
  refactor: rename x/collection events (#639)
  feat: add additional fields into x/collection events (#638)
  refactor: rename x/token events (#637)
  feat: add creator into x/token EventIssue (#636)
  chore(deps): Bump github.com/coinbase/rosetta-sdk-go (#641)
  chore: change `Keeper.space` type to be same with cosmos-sdk
  refactor: remove SetBalance and SetSupply (#629)
  refactor: revert changes in x/slashing proto (#627)
  chore(deps): Bump actions/cache from 3.0.5 to 3.0.6 (#631)
  chore(deps): Bump github.com/prometheus/client_golang (#632)
  chore(deps): Bump actions/setup-go from 2.1.4 to 3.2.1 (#624)
  feat: add Query/TokenClassTypeName (#622)
  feat: add additional information into EventXXXChanged (#621)

Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	CHANGELOG.md
#	client/docs/statik/statik.go
#	simapp/app.go
#	x/wasm/types/events.go
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants