Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog (#346) #349

Merged
merged 1 commit into from
Oct 15, 2021
Merged

docs: update changelog (#346) #349

merged 1 commit into from
Oct 15, 2021

Conversation

egonspace
Copy link

@egonspace egonspace commented Oct 14, 2021

Description

Right relation of CHANGELOG and RELEASE_CHANGELOG

  • main branch before making rc branch
    • CHANGELOG: include only Unreleased set
    • RELEASE_CHANGELOG: include all vx.x.x sets
  • when creating rc branch
    • move all items of Unreleased set to RELEASED_CHANGELOG
    • CHANGELOG: empty Unreleased set
    • RELEASE_CHANGELOG: new vx.x.x set and existing all vx.x.x sets
  • main branch after merging rc branch to main
    • starting with empty CHANGELOG
    • having updated RELEASE_CHANGELOG

But for now, rc0/v0.43.0 doesn't have empty CHANGELOG. It's my mistake.
After merging this PR to main, I'll update CHANGELOG of main branch.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Oct 14, 2021
@egonspace egonspace merged commit e5a2be9 into main Oct 15, 2021
@egonspace egonspace deleted the rc0/v0.43.0 branch October 15, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants