Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove link-modules #156

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

egonspace
Copy link

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Apr 29, 2021
@egonspace egonspace added this to the Initail ebony milestone Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #156 (1043fc4) into v2/develop (1f739c5) will decrease coverage by 1.78%.
The diff coverage is 67.72%.

❗ Current head 1043fc4 differs from pull request most recent head 3cec30a. Consider uploading reports for the commit 3cec30a to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #156      +/-   ##
==============================================
- Coverage       54.99%   53.21%   -1.79%     
==============================================
  Files             812      704     -108     
  Lines           51487    46974    -4513     
==============================================
- Hits            28317    24998    -3319     
+ Misses          20211    19431     -780     
+ Partials         2959     2545     -414     
Impacted Files Coverage Δ
client/grpc/tmservice/query.pb.gw.go 30.06% <ø> (ø)
client/keys/root.go 100.00% <ø> (ø)
client/keys/utils.go 35.29% <ø> (-3.60%) ⬇️
client/utils.go 44.82% <0.00%> (-1.61%) ⬇️
crypto/armor.go 85.89% <ø> (ø)
crypto/keys/ed25519/ed25519.go 67.34% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 86.79% <ø> (ø)
simapp/test_helpers.go 0.49% <0.00%> (-0.01%) ⬇️
types/address.go 65.71% <ø> (ø)
... and 69 more

@egonspace egonspace merged commit 4e43220 into v2/develop Apr 29, 2021
@egonspace egonspace deleted the egon/v2/chore/remove_link_modules branch May 27, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants