docs: correct spec docs of fswap module #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
- Coverage 69.63% 69.62% -0.01%
==========================================
Files 751 751
Lines 62055 61854 -201
==========================================
- Hits 43210 43068 -142
+ Misses 16214 16155 -59
Partials 2631 2631
|
Signed-off-by: 170210 <j170210@icloud.com>
170210
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
170210
added
backport/v0.49.x
documentation
0Tech
reviewed
Jun 13, 2024
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
0Tech
reviewed
Jun 16, 2024
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
jaeseung-bae
previously approved these changes
Jun 24, 2024
Signed-off-by: 170210 <j170210@icloud.com>
jaeseung-bae
previously approved these changes
Jun 24, 2024
Signed-off-by: 170210 <j170210@icloud.com>
jaeseung-bae
approved these changes
Jun 24, 2024
0Tech
approved these changes
Jun 24, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
* docs: correct spec docs of fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct comment of storeKey Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * chore: fix format Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> (cherry picked from commit 7bd6c82) # Conflicts: # CHANGELOG.md
5 tasks
zemyblue
pushed a commit
that referenced
this pull request
Jun 24, 2024
* docs: correct spec docs of fswap module (#1419) * docs: correct spec docs of fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct comment of storeKey Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * chore: fix format Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> (cherry picked from commit 7bd6c82) # Conflicts: # CHANGELOG.md * fix: fix conflict Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: Ki <85928898+170210@users.noreply.github.com> Co-authored-by: 170210 <j170210@icloud.com>
zemyblue
pushed a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jun 24, 2024
…schia#1429) * docs: correct spec docs of fswap module (Finschia#1419) * docs: correct spec docs of fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct comment of storeKey Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * chore: fix format Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> (cherry picked from commit 7bd6c82) # Conflicts: # CHANGELOG.md * fix: fix conflict Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: Ki <85928898+170210@users.noreply.github.com> Co-authored-by: 170210 <j170210@icloud.com> (cherry picked from commit 8c5ab7e)
zemyblue
added a commit
that referenced
this pull request
Jun 24, 2024
* chore: update release changelog for v0.49.1 * docs: correct spec docs of fswap module (backport #1419) (#1429) * docs: correct spec docs of fswap module (#1419) * docs: correct spec docs of fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct comment of storeKey Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * chore: fix format Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * fixup: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> (cherry picked from commit 7bd6c82) # Conflicts: # CHANGELOG.md * fix: fix conflict Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: Ki <85928898+170210@users.noreply.github.com> Co-authored-by: 170210 <j170210@icloud.com> (cherry picked from commit 8c5ab7e) * chore: apply the changes of #1429 --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml