feat: add role-based access control for bridge #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: initial fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct dependencies Signed-off-by: 170210 <j170210@icloud.com> * chore: remove unuse files Signed-off-by: 170210 <j170210@icloud.com> * feat: add proto files Signed-off-by: 170210 <j170210@icloud.com> * chore: make proto-gen Signed-off-by: 170210 <j170210@icloud.com> * chore: fix compile error Signed-off-by: 170210 <j170210@icloud.com> * chore: add new field in params proto Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * docs: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * docs: fix error docs Signed-off-by: 170210 <j170210@icloud.com> * fix: fix consensusversion Signed-off-by: 170210 <j170210@icloud.com> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <j170210@icloud.com> * fix: update proto files Signed-off-by: 170210 <j170210@icloud.com> * fix: fix NewKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com>
* feat: implement genesis related functions Signed-off-by: 170210 <j170210@icloud.com> * chore: use mockgen Signed-off-by: 170210 <j170210@icloud.com> * chore: add tests Signed-off-by: 170210 <j170210@icloud.com> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for test errors Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix appmodulebasic Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: use configuration instead of params Signed-off-by: 170210 <j170210@icloud.com> * chore: refactor new&default fswapped Signed-off-by: 170210 <j170210@icloud.com> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix module_simulation Signed-off-by: 170210 <j170210@icloud.com> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <j170210@icloud.com> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: use io/collection to generate key Signed-off-by: 170210 <j170210@icloud.com> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: remote unnecessary codes Signed-off-by: 170210 <j170210@icloud.com> * fix: add validate for swappable new coin Signed-off-by: 170210 <j170210@icloud.com> * fix: add randomizedGenState Signed-off-by: 170210 <j170210@icloud.com> * fix: fix error doc Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: change proto message fields' name Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com>
* initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature
* impl bridge transfer tx/query * add CLI
* feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums
…Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <j170210@icloud.com> * refactor: remove config¶ms and modify genesis Signed-off-by: 170210 <j170210@icloud.com> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <j170210@icloud.com> * chore: fix simulation Signed-off-by: 170210 <j170210@icloud.com> * chore: correct query cli Signed-off-by: 170210 <j170210@icloud.com> * chore: add query for test Signed-off-by: 170210 <j170210@icloud.com> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com>
* add submitting role proposal feature * feat: addVote * feat: role proposal confirmation logic * add gRPC for RBAC * fix checking trustLevel condition * validate role metadata during initialization * add invariants for metadata * delete expired proposal at begin blocker * add memStore and halting feature * remove redundant gRPC queries * fix endblock logic * add Params test * add dummy guardian for testing * remove redundant invariants * set bridge switch at missing parts * add gov authority * add guardian invariant * add single member query * return error if the address has no role * append genesis validation * add CLI * return all registered members if there is no query string * add unit tests for RBAC * merge `halt` with `resume` as `set-bridge-status` * Add CHANGELOG * add ERRORS docs * apply 0tech review * enhance bridge switch unit test * maintain bridge status metadata based on permanent states * change panic msg for unimplemented features * check duplicate seq in genesis * bridge inactive counter must always be initialization * bridge is always inactive if there is no guardian * start fbridge module after auth/bank * remove redundant invariant checking
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
==========================================
- Coverage 69.98% 69.53% -0.45%
==========================================
Files 663 672 +9
Lines 55440 56103 +663
==========================================
+ Hits 38799 39012 +213
- Misses 14408 14827 +419
- Partials 2233 2264 +31
|
0Tech
approved these changes
May 7, 2024
zemyblue
approved these changes
May 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* add submitting role proposal feature * feat: addVote * feat: role proposal confirmation logic * add gRPC for RBAC * fix checking trustLevel condition * validate role metadata during initialization * add invariants for metadata * delete expired proposal at begin blocker * add memStore and halting feature * remove redundant gRPC queries * fix endblock logic * add Params test * add dummy guardian for testing * remove redundant invariants * set bridge switch at missing parts * add gov authority * add guardian invariant * add single member query * return error if the address has no role * append genesis validation * add CLI * return all registered members if there is no query string * add unit tests for RBAC * merge `halt` with `resume` as `set-bridge-status` * Add CHANGELOG * add ERRORS docs * apply 0tech review * enhance bridge switch unit test * maintain bridge status metadata based on permanent states * change panic msg for unimplemented features * check duplicate seq in genesis * bridge inactive counter must always be initialization * bridge is always inactive if there is no guardian * start fbridge module after auth/bank * remove redundant invariant checking (cherry picked from commit 1c272c9) # Conflicts: # CHANGELOG.md # client/docs/swagger-ui/swagger.yaml # x/ERRORS.md
5 tasks
tkxkd0159
added a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Apply #1350
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml