Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) (backport #1301) #1309

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2024

Description

Cherry-pick of:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1301 done by [Mergify](https://mergify.com).

… (backport cosmos/cosmos-sdk#12303) (#1301)

* fix : Use bytes instead of string comparison in delete validator queue (#12303)

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: William Chong <6198816+williamchong@users.noreply.github.com>
(cherry picked from commit 1038a39)

# Conflicts:
#	CHANGELOG.md
Copy link
Contributor Author

mergify bot commented Mar 26, 2024

Cherry-pick of 1038a39 has failed:

On branch mergify/bp/release/v0.48.x/pr-1301
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit 1038a394c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/staking/keeper/validator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (a496d32) to head (ff40409).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.48.x    #1309      +/-   ##
===================================================
- Coverage            69.78%   69.78%   -0.01%     
===================================================
  Files                  646      646              
  Lines                67532    67541       +9     
===================================================
+ Hits                 47130    47134       +4     
- Misses               18215    18218       +3     
- Partials              2187     2189       +2     
Files Coverage Δ
x/staking/keeper/validator.go 81.09% <54.54%> (-1.17%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech added A: bug Something isn't working C:x/staking and removed conflicts labels Mar 27, 2024
@0Tech 0Tech self-assigned this Mar 27, 2024
jaeseung-bae
jaeseung-bae previously approved these changes Mar 29, 2024
@0Tech 0Tech merged commit 506f8ff into release/v0.48.x Mar 29, 2024
28 of 29 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v0.48.x/pr-1301 branch March 29, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants