Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow Creating test network without init #128

Merged
merged 1 commit into from
Apr 15, 2021
Merged

chore: Allow Creating test network without init #128

merged 1 commit into from
Apr 15, 2021

Conversation

kukugi
Copy link
Contributor

@kukugi kukugi commented Apr 14, 2021

Description

add new function to create test network without init. because test case will initialize chain

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@kukugi kukugi self-assigned this Apr 14, 2021
@kukugi kukugi changed the title feat: Allow Creating test network without init chore: Allow Creating test network without init Apr 14, 2021
@jinsan-line
Copy link
Contributor

@kukugi Do you intend to commit go.sum?

@kukugi
Copy link
Contributor Author

kukugi commented Apr 14, 2021

@kukugi Do you intend to commit go.sum?

no, revert this thx 👍

@@ -375,6 +375,33 @@ func New(t *testing.T, cfg Config) *Network {
return network
}

// New creates a new Network for integration tests without init.
func NewWithoutInit(t *testing.T, cfg Config, baseDir string, validators []*Validator) *Network {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it use this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be used when running lbm node in lbm cli-test

@kukugi kukugi merged commit 6c3cf97 into Finschia:v2/develop Apr 15, 2021
@kukugi kukugi deleted the feat/test_network branch April 15, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants