Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export x/collection params into genesis #1268

Merged
merged 5 commits into from
Mar 22, 2024
Merged

fix: export x/collection params into genesis #1268

merged 5 commits into from
Mar 22, 2024

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 6, 2024 •
edited
Loading

Description

x/collection does not export its params into genesis. This patch addresses the problem.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Mar 6, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.41%. Comparing base (819a938) to head (9a102b4).

❗ Current head 9a102b4 differs from pull request most recent head be49729. Consider uploading reports for the commit be49729 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   70.42%   70.41%   -0.02%     
==========================================
  Files         643      643              
  Lines       54701    54694       -7     
==========================================
- Hits        38524    38513      -11     
- Misses      14007    14009       +2     
- Partials     2170     2172       +2
Files Coverage Δ
x/collection/keeper/genesis.go 95.52% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@0Tech 0Tech marked this pull request as ready for review March 6, 2024 11:44
jaeseung-bae
jaeseung-bae previously approved these changes Mar 7, 2024
View reviewed changes
zemyblue
zemyblue reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the confliction.

jaeseung-bae
jaeseung-bae previously approved these changes Mar 19, 2024
View reviewed changes
@0Tech 0Tech requested a review from jaeseung-bae March 21, 2024 10:45
@0Tech 0Tech merged commit e86b980 into Finschia:main Mar 22, 2024
33 checks passed
@0Tech 0Tech deleted the collection-export-params branch March 22, 2024 00:52
mergify bot pushed a commit that referenced this pull request Mar 22, 2024
@0Tech @mergify
fix: export x/collection params into genesis (#1268)
8c287d0 
* Export params

* Update CHANGELOG.md

* Move position

(cherry picked from commit e86b980)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Mar 22, 2024
Merged
5 tasks
0Tech added a commit that referenced this pull request Mar 22, 2024
@mergify @0Tech
fix: export x/collection params into genesis (backport #1268) (#1290)
66a0114 
* fix: export x/collection params into genesis (#1268)

* Export params

* Update CHANGELOG.md

* Move position

(cherry picked from commit e86b980)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

Assignees

@0Tech 0Tech

Labels
A: bug Something isn't working backport/v0.48.x C:x/collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0Tech @zemyblue @jaeseung-bae