Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate legacy features on x/token,collection #1201

Merged
merged 6 commits into from
Jan 5, 2024
Merged

chore: deprecate legacy features on x/token,collection #1201

merged 6 commits into from
Jan 5, 2024

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jan 4, 2024 •
edited
Loading

Description

This patch would deprecate following features on original modules:

  • x/token
    • all features
  • x/collection
    • fungible tokens
      • common
        • FTClass
        • FT
      • Event
        • EventCreatedFTClass
        • EventMintedFT
      • Genesis
        • GenesisState.next_class_ids.fungible
      • Query
        • FTSupply(), QueryFTSupplyRequest, QueryFTSupplyResponse
        • FTMinted(), QueryFTMintedRequest, QueryFTMintedResponse
        • FTBurnt(), QueryFTBurntRequest, QueryFTBurntResponse
      • Msg
        • SendFT(), MsgSendFT, MsgSendFTResponse
        • OperatorSendFT(), MsgOperatorSendFT, MsgOperatorSendFTResponse
        • IssueFT(), MsgIssueFT, MsgIssueFTResponse
        • MintFT(), MsgMintFT, MsgMintResponse
        • BurnFT(), MsgBurnFT, MsgBurnFTResponse
        • OperatorBurnFT(), MsgOperatorBurnFT, MsgOperatorBurnFTResponse
    • non-fungible tokens hierarchy
      • common
        • Params.depth_limit, Params.width_limit
      • Event
        • EventAttached
        • EventDetached
        • EventOwnerChanged
        • EventRootChanged
      • Genesis
        • GenesisState.parents
        • ContractTokenRelations
        • TokenRelation
      • Query
        • Root(), QueryRootRequest, QueryRootResponse
        • HasParent(), QueryHasParentRequest, QueryHasParentResponse
        • Parent(), QueryParentRequest, QueryParentResponse
        • Children(), QueryChildrenRequest, QueryChildrenResponse
      • Msg
        • Attach(), MsgAttach, MsgAttachResponse
        • Detach(), MsgDetach, MsgDetachResponse
        • OperatorAttach(), MsgOperatorAttach, MsgOperatorAttachResponse
        • OperatorDetach(), MsgOperatorDetach, MsgOperatorDetachResponse

Motivation and context

The features would be wiped out from the sdk in the next major release.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Jan 4, 2024
@0Tech 0Tech changed the title chore: deprecate legacy features chore: deprecate legacy features on x/token,collection Jan 4, 2024
@0Tech 0Tech changed the base branch from release/v0.48.x to main January 4, 2024 04:00
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1bab87) 69.74% compared to head (fe371cf) 69.74%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1201   +/-   ##
=======================================
  Coverage   69.74%   69.74%           
=======================================
  Files         643      643           
  Lines       67255    67255           
=======================================
  Hits        46906    46906           
  Misses      18176    18176           
  Partials     2173     2173

@0Tech 0Tech marked this pull request as ready for review January 4, 2024 04:47
tkxkd0159
tkxkd0159 previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zemyblue
zemyblue reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update swagger also.

@0Tech
Copy link
Collaborator Author

0Tech commented Jan 5, 2024

Please update swagger also.

It seems the change does not affect the output for swagger.

@0Tech 0Tech merged commit 3babbe5 into Finschia:main Jan 5, 2024
40 checks passed
@0Tech 0Tech deleted the deprecate branch January 5, 2024 07:02
mergify bot pushed a commit that referenced this pull request Jan 5, 2024
@0Tech @mergify
chore: deprecate legacy features on x/token,collection (#1201)
ec71882 
* Deprecate all the x/token features

* Deprecate x/collection fungible token features

* Deprecate x/collection attach features

* Update CHANGELOG.md

* Lint

* Apply feedbacks on the PR

(cherry picked from commit 3babbe5)

# Conflicts:
#	CHANGELOG.md
#	tests/mocks/types_module_module.go
@mergify mergify bot mentioned this pull request Jan 5, 2024
Merged
0Tech added a commit that referenced this pull request Jan 5, 2024
@mergify @0Tech
chore: deprecate legacy features on x/token,collection (backport #1201)…
cb6669c 
… (#1202)

* chore: deprecate legacy features on x/token,collection (#1201)

* Deprecate all the x/token features

* Deprecate x/collection fungible token features

* Deprecate x/collection attach features

* Update CHANGELOG.md

* Lint

* Apply feedbacks on the PR

(cherry picked from commit 3babbe5)

# Conflicts:
#	CHANGELOG.md
#	tests/mocks/types_module_module.go

* Resolve conflicts

* Revert updating golangci version

---------

Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

Assignees

@0Tech 0Tech

Labels
backport/v0.48.x C:x/collection C:x/token
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0Tech @zemyblue @tkxkd0159