Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add abbreviated vote option to x/foundation vote cli #1127

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Sep 14, 2023

Description

This patch would allow users to use abbreviated vote option for the foundation vote cli.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: improvement Changes in existing functionality C:x/foundation x/foundation module labels Sep 14, 2023
@0Tech 0Tech self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1127 (0b58a27) into main (b64541a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   62.05%   62.06%           
=======================================
  Files         656      656           
  Lines       78996    79003    +7     
=======================================
+ Hits        49021    49031   +10     
+ Misses      27286    27284    -2     
+ Partials     2689     2688    -1     
Files Changed Coverage Δ
x/foundation/client/testutil/suite.go 99.41% <100.00%> (+1.70%) ⬆️
x/foundation/client/testutil/tx.go 100.00% <100.00%> (ø)

@0Tech 0Tech marked this pull request as ready for review September 15, 2023 11:37
@0Tech 0Tech marked this pull request as draft October 31, 2023 01:15
@tkxkd0159 tkxkd0159 self-requested a review October 31, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants