Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/foundation): rollback codec for MsgUpdateParams #1108

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Sep 4, 2023

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae changed the base branch from main to rc/v0.48.0-rcx September 4, 2023 09:28
@jaeseung-bae jaeseung-bae changed the title feat(x/foundation): ollback codec for MsgUpdateParams feat(x/foundation): rollback codec for MsgUpdateParams Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1108 (f7b564d) into rc/v0.48.0-rcx (4f7b891) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1108   +/-   ##
===============================================
  Coverage           69.76%   69.76%           
===============================================
  Files                 645      645           
  Lines               67469    67482   +13     
===============================================
+ Hits                47067    47081   +14     
+ Misses              18214    18213    -1     
  Partials             2188     2188           
Files Changed Coverage Δ
x/foundation/codec.go 100.00% <100.00%> (ø)
x/foundation/msgs.go 68.97% <100.00%> (+1.16%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update statik file through make update-swagger-docs.

proto/lbm/foundation/v1/tx.proto Show resolved Hide resolved
@jaeseung-bae jaeseung-bae marked this pull request as ready for review September 4, 2023 10:18
@zemyblue zemyblue added this to the v0.48.0 milestone Sep 4, 2023
@zemyblue zemyblue added A: bug Something isn't working C:x/collection labels Sep 4, 2023
@jaeseung-bae jaeseung-bae merged commit 022614f into rc/v0.48.0-rcx Sep 5, 2023
37 of 38 checks passed
@jaeseung-bae jaeseung-bae deleted the feat/foundation-rollback-codec branch September 5, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants