Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: automate EventTypeMessage inclusion in every message execution (backport cosmos/cosmos-sdk#13532) #1063

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 2, 2023

Description

This patch would add message event to every msgs in a tx. The event contains following attributes:

  • sender
  • action
  • module

You may refer to the corresponding PR of the upstream.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 0Tech
❌ julienrbrt
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1063 (d9683c0) into release/v0.47.x (92d75cf) will increase coverage by 0.09%.
Report is 1 commits behind head on release/v0.47.x.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.47.x    #1063      +/-   ##
===================================================
+ Coverage            62.04%   62.14%   +0.09%     
===================================================
  Files                  655      655              
  Lines                78983    78860     -123     
===================================================
+ Hits                 49004    49005       +1     
+ Misses               27293    27169     -124     
  Partials              2686     2686              
Files Changed Coverage Δ
x/auth/vesting/msg_server.go 67.27% <ø> (-3.70%) ⬇️
x/bank/keeper/msg_server.go 3.84% <ø> (+0.81%) ⬆️
x/bank/types/events.go 0.00% <ø> (ø)
x/crisis/keeper/msg_server.go 0.00% <ø> (ø)
x/distribution/keeper/msg_server.go 2.66% <ø> (+0.77%) ⬆️
x/evidence/keeper/msg_server.go 16.66% <ø> (+6.66%) ⬆️
x/gov/keeper/msg_server.go 2.24% <0.00%> (+0.59%) ⬆️
x/slashing/keeper/msg_server.go 14.28% <ø> (+5.19%) ⬆️
x/staking/keeper/msg_server.go 0.74% <ø> (+0.06%) ⬆️
baseapp/baseapp.go 78.99% <100.00%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

@0Tech

This comment was marked as resolved.

@0Tech
Copy link
Collaborator Author

0Tech commented Aug 3, 2023

We should apply this PR as is.

@0Tech 0Tech marked this pull request as ready for review August 3, 2023 09:06
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check checklist in description.

@0Tech 0Tech merged commit e669c6f into Finschia:release/v0.47.x Aug 10, 2023
28 checks passed
@0Tech 0Tech deleted the automate-event branch August 10, 2023 06:34
@zemyblue zemyblue added this to the v0.47.3 milestone Aug 16, 2023
0Tech added a commit to Finschia/wasmd that referenced this pull request Aug 18, 2023
* Backport subset of CosmWasm#1149

* Update CHANGELOG.md

* Update dependencies
0Tech added a commit to 0Tech/finschia-sdk that referenced this pull request Aug 24, 2023
…ion (backport cosmos/cosmos-sdk#13532) (Finschia#1063)

* refactor: automate EventTypeMessage inclusion in every message execution (#13532)

* Fix the test requirement and leave the hint

* Update CHANGELOG.md

* Lint

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
0Tech added a commit that referenced this pull request Aug 24, 2023
…ion (backport #1063) (#1090)

* refactor: automate EventTypeMessage inclusion in every message execution (backport cosmos/cosmos-sdk#13532) (#1063)

* refactor: automate EventTypeMessage inclusion in every message execution (#13532)

* Fix the test requirement and leave the hint

* Update CHANGELOG.md

* Lint

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>

* Update CHANGELOG.md

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
da1suk8 added a commit to da1suk8/wasmd that referenced this pull request Aug 25, 2023
* Backport subset of CosmWasm#1149

* Update CHANGELOG.md

* Update dependencies
da1suk8 added a commit to Finschia/wasmd that referenced this pull request Aug 25, 2023
…105)

* feat: apply Finschia/finschia-sdk#1063 (#81)

* Backport subset of CosmWasm#1149

* Update CHANGELOG.md

* Update dependencies

* build: bump finschia-sdk from v0.48.0-rc1 to v0.48.0-rc2

* fix: delete message event

Because message event move to finschia-sdk

* docs: add CHANGELOG

* reflect comment
0Tech added a commit to Finschia/wasmd that referenced this pull request Nov 27, 2023
* Backport subset of CosmWasm#1149

* Update CHANGELOG.md

* Update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants