Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the api for querying next account number (backport #1011) #1026

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jun 8, 2023

Description

backport #1011

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

* feat: add `NextAccountNumber` query api in cosmos.auth.v1beta1.query proto

* feat: implement query account number in x/auth module

* chore: update changelog.

* fix: line error

* fix: proto function typo

(cherry picked from commit 94b5a52)
@zemyblue zemyblue self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1026 (281f7a5) into rc/v0.47.0.1-rc (154d1aa) will increase coverage by 0.00%.
The diff coverage is 78.26%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           rc/v0.47.0.1-rc    #1026   +/-   ##
================================================
  Coverage            62.04%   62.04%           
================================================
  Files                  655      655           
  Lines                78960    78983   +23     
================================================
+ Hits                 48987    49004   +17     
- Misses               27289    27293    +4     
- Partials              2684     2686    +2     
Impacted Files Coverage Δ
x/auth/keeper/grpc_query.go 57.14% <62.50%> (+0.62%) ⬆️
x/auth/keeper/keeper.go 74.78% <86.66%> (+1.78%) ⬆️

... and 1 file with indirect coverage changes

jaeseung-bae
jaeseung-bae previously approved these changes Jun 8, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
@tkxkd0159 tkxkd0159 self-requested a review June 8, 2023 09:46
@zemyblue zemyblue merged commit 92d75cf into Finschia:rc/v0.47.0.1-rc Jun 8, 2023
@zemyblue zemyblue deleted the feat/1011 branch June 8, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants