Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix a typo in comments #102

Merged
merged 1 commit into from
Mar 25, 2021
Merged

docs: fix a typo in comments #102

merged 1 commit into from
Mar 25, 2021

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Mar 23, 2021 •
edited
Loading

Description

fix a typo

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work. (diff is enough small and describing)
  • Wrote unit and integration tests (not needed because it is just a fix typo)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) (not needed)
  • Added relevant godoc comments. (not needed)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md (Is this needed?)
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes (Not reported?)

@loloicci loloicci self-assigned this Mar 23, 2021
@LINK-Network-Dev
Copy link

tps:344

whylee259
whylee259 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 7e18cae into Finschia:develop Mar 25, 2021
@loloicci loloicci deleted the fix-a-typo branch March 25, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whylee259 whylee259 whylee259 approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

@brew0722 brew0722 brew0722 approved these changes

Assignees

@loloicci loloicci

Labels
C:WASM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loloicci @LINK-Network-Dev @whylee259 @shiki-tak @brew0722