Skip to content

Commit

Permalink
Emit header in MsgUpdateClient events (#8624)
Browse files Browse the repository at this point in the history
* emit header in update client msg

* update CHANGELOG

* update spec

* fix nil header bug

* use JSON encoding for emitting header

* Update x/ibc/core/spec/06_events.md

* use proto for encoding

* add tests

* encode to hex before emitting header in event

* add comment addressing reasoning for hex encoding

* Update CHANGELOG.md

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
  • Loading branch information
3 people authored and dudong2 committed Mar 11, 2022
1 parent ab9cba8 commit fa42b5f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions x/ibc/core/02-client/types/encoding_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ package types_test

import (
"github.com/line/lbm-sdk/x/ibc/core/02-client/types"
ibctmtypes "github.com/line/lbm-sdk/x/ibc/light-clients/99-ostracon/types"
ibcoctypes "github.com/line/lbm-sdk/x/ibc/light-clients/99-ostracon/types"
)

func (suite *TypesTestSuite) TestMarshalHeader() {

cdc := suite.chainA.App.AppCodec()
h := &ibctmtypes.Header{
h := &ibcoctypes.Header{
TrustedHeight: types.NewHeight(4, 100),
}

Expand Down

0 comments on commit fa42b5f

Please sign in to comment.