Skip to content
This repository was archived by the owner on Nov 19, 2018. It is now read-only.

Fixed some code style inconsistencies in NodeJS example #53

Merged
merged 3 commits into from
Aug 17, 2016

Conversation

SamuelBolduc
Copy link
Contributor

I'm really not sure what are the code standards in the project for NodeJS, but there were some obvious inconsistencies here and there. I fixed those, without changing chosen code styles.

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2016

CLA assistant check
All committers have signed the CLA.

@rnicholus
Copy link
Member

I'm really not sure what are the code standards in the project for NodeJS

Neither am I! This could benefit from an .editorconfig file and the some code style enforcement. But those are both among many (many) low-priority Fine Uploader-related items on my list at the moment.

Thanks for the contribution. I'll take a closer look soon. The version number in the package.json should be update to indicate that this is a hotfix revision. If you have any other suggestions, do let me know (or open up another PR).

One more thing - have you tested locally to be sure that this doesn't obviously break request handling?

@SamuelBolduc
Copy link
Contributor Author

One more thing - have you tested locally to be sure that this doesn't obviously break request handling?

Yup, just tested, everything still works fine.

One more thing - have you tested locally to be sure that this doesn't obviously break request handling?

I bumped the patch version in 423af6f

This could benefit from an .editorconfig file and the some code style enforcement.

I agree. When I have the time I might take on that task - it should not be very hard to upgrade the code to actual Javascript style standards.

@rnicholus rnicholus merged commit b90a57b into FineUploader:master Aug 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants