Skip to content

Comments

[fix] search-api 의존성 잘못적은거 삭제 안하고 push해버려서 다시..#97

Merged
nasohee merged 1 commit intodevelopfrom
fix-search-api
Oct 13, 2025
Merged

[fix] search-api 의존성 잘못적은거 삭제 안하고 push해버려서 다시..#97
nasohee merged 1 commit intodevelopfrom
fix-search-api

Conversation

@nasohee
Copy link
Collaborator

@nasohee nasohee commented Oct 13, 2025

Related issue 🛠

  • closed #이슈넘버

Work Description 📝

  • 까먹고 그냥 푸시해서 오류가 나버려서 수정하였습니다..
    꼭 확인 한번 더 하고 머지하겠습니다...

Screenshot 📸

Uncompleted Tasks 😅

  • Task1

To Reviewers 📢

Summary by CodeRabbit

  • 버그 수정

    • 검색 필터의 종 항목이 잘못 표시·전달되던 문제를 사용자 표시 이름 기준으로 매핑해 일관되게 노출 및 필터링되도록 개선했습니다.
  • 작업(Chores)

    • Firebase 연동을 제거하여 빌드 구성을 단순화했습니다.

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

  • Android 앱 모듈에서 Google Services 플러그인과 Firebase 의존성 제거.
  • SearchFilterUiModel.toDomain에서 species 매핑을 SpeciesType.*.species → SpeciesType.*.displayName로 변경.

Changes

Cohort / File(s) Summary of changes
빌드 구성 정리
app/build.gradle.kts
com.google.gms.google-services 플러그인 제거. Firebase BOM 및 firebase-config-ktx, firebase-analytics-ktx, firebase-common-ktx 의존성 제거.
UI 모델 매핑 수정
app/src/main/java/.../search/model/SearchFilterUiModel.kt
toDomain에서 DOG/CAT/ETC의 매핑을 SpeciesType.*.speciesSpeciesType.*.displayName로 변경. 나머지 로직/분기 동일.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

🐶소희, refactor

Suggested reviewers

  • ikseong00

Poem

빌드에서 구름( Firebase )을 살짝 걷어내고,
종(種)의 이름은 좀 더 또렷한 목소리로.
플러그인은 가벼이, 매핑은 선명히,
코드의 숨결이 한층 산뜻해졌네.
🐾 오늘도 깔끔하게, 내일은 더 담백하게!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-search-api

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3994ca and fc0f277.

📒 Files selected for processing (2)
  • app/build.gradle.kts (0 hunks)
  • app/src/main/java/com/example/findu/presentation/ui/search/model/SearchFilterUiModel.kt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nasohee nasohee merged commit 245d129 into develop Oct 13, 2025
1 check was pending
@coderabbitai coderabbitai bot mentioned this pull request Oct 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant