Feat/better resolution events #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (options.CurrentValue.IgnoredIdentifiers.Contains(identifier, StringComparer.OrdinalIgnoreCase)) | ||
| { | ||
| (loggerFactory?.CreateLogger(GetType()) ?? NullLogger.Instance).LogInformation( | ||
| "Ignored identifier: {Identifier}", identifier); | ||
| tenantResoloverLogger.LogDebug("Ignored identifier: {Identifier}", identifier); |
Check failure
Code scanning / CodeQL
Log entries created from user input High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to sanitize the identifier before logging it. Since the log entries are plain text, we should remove any newline characters from the identifier to prevent log forging attacks. This can be done using the String.Replace method to replace newline characters with an empty string.
Suggested changeset
1
src/Finbuckle.MultiTenant/TenantResolver.cs
| @@ -68,3 +68,3 @@ | ||
| { | ||
| tenantResoloverLogger.LogDebug("Ignored identifier: {Identifier}", identifier); | ||
| tenantResoloverLogger.LogDebug("Ignored identifier: {Identifier}", identifier?.Replace(Environment.NewLine, "").Replace("\n", "").Replace("\r", "")); | ||
| identifier = null; |
Copilot is powered by AI and may make mistakes. Always verify output.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
# [9.0.0](v8.0.0...v9.0.0) (2024-11-13) * multitenant db factory ([#894](#894)) ([ea216ff](ea216ff)) ### Bug Fixes * remove deprecated dotnet ([#891](#891)) ([1429cbf](1429cbf)) ### Features * add multitenant db factory method ([#896](#896)) ([8728447](8728447)) * better tenant resolution events ([#897](#897)) ([956ca36](956ca36)) * dotnet 9 support ([#893](#893)) ([4be1b88](4be1b88)) * Make builds deterministic and set latest GH actions ([#889](#889)) ([d82f89d](d82f89d)) ### Reverts * Revert "multitenant db factory ([#894](#894))" ([#895](#895)) ([0e164a8](0e164a8)) ### BREAKING CHANGES * `OnTenantResolved` and `OnTenantNotResolved` are no longer used. Use the `OnStrategyResolveCompleted`, `OnStoreResolveCompleted`, and `OnTenantResolveCompleted` events instead. * `MultiTenantDbContext` constructors accepting ITenantInfo removed, use `MultiTenantDbContext.Create` factory method * `MultiTenantDbContext` constructors accepting ITenantInfo removed, use `MultiTenantDbContext .Create` factory method instead * net6.0 and net7.0 are no longer supported targets. * Dotnet runtime specific dependencies now float to the latest patch version and are locked at release time with a NuGet lock file. This is a security mitigation and may break some builds not on the latest SDKs.
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnStrategyResolveCompleted- Called after each strategy has attempted to resolve a tenant identifier. TheIdentifierFoundproperty will betrueif the strategy resolved a tenant identifier. TheIdentifierpropertycontains the resolved tenant identifier and can be changed by the event handler to override the strategy's result
OnStoreResolveCompleted- Called after each store has attempted to resolve a tenant. TheTenantFoundpropertywill be
trueif the store resolved a tenant. TheTenantInfoproperty contains the resolved tenant and can bechanged by the event handler to override the store's result. A non-null
TenantInfoobject will stop the resolverfrom trying additional strategies and stores.
OnTenantResolveCompleted- Called once after a tenant has been resolved. TheMultiTenantContextpropertycontains the resolved multi-tenant context and can be changed by the event handler to override the resolver's
result.