-
Notifications
You must be signed in to change notification settings - Fork 0
Feat: dynamic 'unstable' body blocks #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lastHokage
wants to merge
10
commits into
main
Choose a base branch
from
feat/dynamic-story-blocks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new way of adding storyblock to spark.
…unstableBodyBloks and move it's location in the readme
…the --validationKeywords flag to add a sparkGenerateStoryblock to the gallery
adgad
reviewed
Sep 1, 2025
…of the build scripts
lastHokage
commented
Sep 9, 2025
…s/content-tree into feat/dynamic-story-blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step:
Schema Driven Componentfor SparkThis PR is the first step toward using Content Tree as the source of truth for body block configuration in Spark.
You can read more background in our Reusable Components doc.
As our first example, we’ve added an
Galleryblock.It’s a simple, dynamic block with a few primitive fields (string, boolean) and one image node/type. More fields can be added later as needed — this is just a starting point to validate the pipeline end-to-end
Key changes
Add
--validationKeywordsflag in the build state to add thesparkGenerateStoryblock:truekey-value pair to the Gallery to be utilised in spark.Gallery→ first dynamic block wired into the Spark.