Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Specialist Titles support adding vimeo video embeds to articles. This PR adds support to:
I've basically followed the same pattern as YoutubeVideo, as discussed in #72
Question
Currently we publish the vimeo link to bodyXML is exactly the same as the youtube one:
I assume that's what we want for external bodyXML as well? so i've kept it the same
Notes for reviewer
I have no idea what I'm doing with Go, so please provide extra scrutiny! Have basically just copy/pasted what we do for External Video.
I've tested using
go testin both libraries (there were some already failing tests, but have validated that the tests I added are working)