fix metrics path ref error (apache#2553)

FinalT · Jan 10, 2024 · b91c85e · b91c85e
1 parent 4f21a41
commit b91c85e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/metrics/prometheus/registry.go b/metrics/prometheus/registry.go
@@ -152,7 +152,7 @@ func (p *promMetricRegistry) Export() {
 
 func (p *promMetricRegistry) exportHttp() {
 	mux := http.NewServeMux()
-	path := p.url.GetParam(constant.PrometheusDefaultMetricsPath, constant.PrometheusDefaultMetricsPath)
+	path := p.url.GetParam(constant.PrometheusExporterMetricsPathKey, constant.PrometheusDefaultMetricsPath)
 	port := p.url.GetParam(constant.PrometheusExporterMetricsPortKey, constant.PrometheusDefaultMetricsPort)
 	mux.Handle(path, promhttp.InstrumentMetricHandler(p.r, promhttp.HandlerFor(p.gather, promhttp.HandlerOpts{})))
 	srv := &http.Server{Addr: ":" + port, Handler: mux}

diff --git a/metrics/prometheus/registry_test.go b/metrics/prometheus/registry_test.go
@@ -43,8 +43,8 @@ var (
 	url      = common.NewURLWithOptions(
 		common.WithProtocol(constant.ProtocolPrometheus),
 		common.WithParamsValue(constant.PrometheusExporterEnabledKey, "true"),
-		common.WithParamsValue(constant.PrometheusExporterMetricsPortKey, constant.PrometheusDefaultMetricsPort),
-		common.WithParamsValue(constant.PrometheusExporterMetricsPathKey, constant.PrometheusDefaultMetricsPath),
+		common.WithParamsValue(constant.PrometheusExporterMetricsPortKey, "9999"),
+		common.WithParamsValue(constant.PrometheusExporterMetricsPathKey, "/prometheus"),
 		common.WithParamsValue(constant.ApplicationKey, "dubbo"),
 		common.WithParamsValue(constant.AppVersionKey, "1.0.0"),
 		common.WithParamsValue(constant.PrometheusPushgatewayEnabledKey, "true"),