Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release arm64 binaries #359

Closed
wants to merge 1 commit into from

Conversation

ccmtaylor
Copy link

@ccmtaylor ccmtaylor commented Mar 25, 2021

Now that Go 1.16 is out, we can compile arm64 binaries for macOS.

I tested the resulting binary on my laptop (although I also built it on macOS/arm64). It seemed to work alright.

Fixes: #329

@ccmtaylor
Copy link
Author

I think the failing validations are bogus. There is a nil check right above the line that the check is complaining about.

        if csrPEM == nil {
                log.Fatalln("ERROR: failed to read the CSR: unexpected content")
        }
        if csrPEM.Type != "CERTIFICATE REQUEST" &&    // this is line 220
                csrPEM.Type != "NEW CERTIFICATE REQUEST" {
                log.Fatalln("ERROR: failed to read the CSR: expected CERTIFICATE REQUEST, got " + csrPEM.Type)
        }

In any case, they are unrelated to this PR which doesn't touch any of the code, nor the CI test configuration.

Now that Go 1.16 is out, we can compile arm64 binaries for macOS.

Fixes: FiloSottile#329
@FiloSottile
Copy link
Owner

Ah, merged a duplicate (#433), my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build mkcert release for Apple Silicon
2 participants