Decrypt with passphrase from stdin#641
Closed
AlexanderYastrebov wants to merge 1 commit intoFiloSottile:mainfrom
Closed
Decrypt with passphrase from stdin#641AlexanderYastrebov wants to merge 1 commit intoFiloSottile:mainfrom
AlexanderYastrebov wants to merge 1 commit intoFiloSottile:mainfrom
Conversation
Read passphrase from stdin when it is not used for input data. Fixes FiloSottile#603
| if in != os.Stdin && !term.IsTerminal(int(os.Stdin.Fd())) { | ||
| passphrase = func() (string, error) { | ||
| b, err := io.ReadAll(os.Stdin) | ||
| b = bytes.TrimRight(b, "\n") |
Contributor
Author
There was a problem hiding this comment.
Trimming newline to make test case work and improve usability when passphrase is coming from a file or via echo.
Owner
|
I've implemented this through a plugin. See #256 (comment) for usage and a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read passphrase from stdin when it is not used for input data.
Fixes #603