-
Notifications
You must be signed in to change notification settings - Fork 3
Add GitHub workflow to detect apps affected by code changes [skip percy] #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@@ -68,8 +73,10 @@ jobs: | |||
|
|||
- name: Run Cypress Tests without Percy | |||
if: steps.test-type.outputs.skip_percy == 'true' | |||
run: npm run test:cypress | |||
run: npm run test:cypress || echo "Script missing, skipping this step..." | |||
continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This morning I woke up and the first thing I thought was... Will this also cause the tests to fail silently if Cypress throws an error?? To be tested 😄
3e2fd54
to
0c399c4
Compare
Important On a broader note, I realized that this implementation only tracks changes in the |
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
# For PRs, compare against the base branch
TURBO_OUTPUT=$(npx turbo run build --filter=...[origin/${{ github.base_ref }}] --dry=json)
else
# For pushes, compare against the previous commit
TURBO_OUTPUT=$(npx turbo run build --filter=...[HEAD^] --dry=json)
fi |
We should rename the folder to the same name as package.json. So we can add a |
@CharlyMartin ~ I moved this to draft until we figured it out. 🙏🏼 |
@mirhamasala I'm hoping that something as simple as that will work: #1465 |
📝 Description
This pull request adds a GitHub action
apps-detect-changes.yml
to determine whether an app is affected by code changes in a each PR. The output is then used byapps-cypress-percy-test.yml
To only run the tests in the apps with code changes.This PR also fixes the deps of the UXIT app as it was preventing the action from running properly.
🧪 How to Test
apps-detect-changes.yml
picks up changes only in the relevant apps(Tests previously made on a separate PR #1456)
🔖 Resources