updating the deposit to no longer accept funds from the investor. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead, it will pull the funds from the investor's address. it is assumed that all the funds committed are being deposited - for now
Taztingo
reviewed
Aug 29, 2023
Taztingo
reviewed
Aug 29, 2023
Taztingo
reviewed
Aug 29, 2023
|
is this a work around to not being to sending restricted marker with a contract exec message as funds? |
| .expect("Should not throw error"); | ||
| assert_eq!(0, response.messages.len()); | ||
| assert_eq!(1, response.messages.len()); |
There was a problem hiding this comment.
can we add any assertions to ensure we have the correct sender / recipient relationship on the marker transfer message?
Yes - before, the funds were being sent along with the message - and investors can't send restricted markers (usd.deposit) |
wrouten-figure
previously approved these changes
Aug 29, 2023
Taztingo
reviewed
Aug 29, 2023
Taztingo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead, it will pull the funds from the investor's address. it is assumed that all the funds committed are being deposited - for now