Skip to content

Add bufferCapacity to apply backpressure to the kafka consumer #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtps merged 3 commits into from
Dec 7, 2022
Merged

Add bufferCapacity to apply backpressure to the kafka consumer #43

mtps merged 3 commits into from
Dec 7, 2022

Conversation

@mtps
Copy link
Collaborator

@mtps mtps commented Dec 7, 2022

  • The noAck consumer had no way of knowing if the channel was at capacity and kept pushing more and more data into the pipeline. If the consumer slowed down on the other end, the producer would continue to push records, resulting in OOM.

@mtps mtps requested a review from wbaker-figure as a code owner December 7, 2022 05:12
@mtps mtps merged commit bae913a into main Dec 7, 2022
@mtps mtps deleted the mtps/fix-memory-leak-in-noack branch December 7, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchaing-figure rchaing-figure Awaiting requested review from rchaing-figure

@piercetrey-figure piercetrey-figure Awaiting requested review from piercetrey-figure

1 more reviewer

@wbaker-figure wbaker-figure wbaker-figure approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtps @wbaker-figure