Skip to content

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Mar 20, 2020

This pull request seeks to remove the aria-label attribute from the rendered iframe. Because the iframe is already rendered with aria-hidden, it is removed from the accessibility tree and thus the aria-label would never be used. Furthermore, the label itself may or may not be readable in its current form, depending how well assistive technology interprets the dash of "resize-listener" (vs., say, "resize listener").

References:

@FezVrasta FezVrasta merged commit e5793b1 into FezVrasta:master Mar 20, 2020
@FezVrasta
Copy link
Owner

Thanks!

@aduth aduth deleted the remove/aria-label branch March 20, 2020 17:34
@aduth
Copy link
Contributor Author

aduth commented Jun 3, 2020

Thanks for merging this @FezVrasta . Any chance a release could be published which includes this change? It's come up again in our project at WordPress/gutenberg#22864 .

@FezVrasta
Copy link
Owner

Done

@aduth
Copy link
Contributor Author

aduth commented Jun 3, 2020

Thanks for the quick turnaround! ❤️

@FezVrasta
Copy link
Owner

It only took 6 months 😂

@aduth
Copy link
Contributor Author

aduth commented Jun 3, 2020

Hah! Well, just to be clear, I meant between my follow-up and the release 😉

It's appreciated all the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants