Skip to content

Conversation

brianium
Copy link
Contributor

@FezVrasta many thanks for this library. I've been using it with popper.js and it is 💯

I ran into an issue recently with Safari throwing errors when using this component inside of a react portal.

It seems that in this browser React stubs in a window for contentDocument.defaultView that is not actually an event listener. So when ResizeAware unmounts in Safari - it throws an error complaining that removeEventListener is not a function.

I included a simple fix that solves my issues, and might just make things more robust in general?

Let me know if I can do anything to help get this merged 😄

Many thanks again for the work you do on these libs!

@FezVrasta
Copy link
Owner

Thanks! May you add a little comment there to explain what's going on/why it's needed, for future reference?

@brianium
Copy link
Contributor Author

Sure thing!

@brianium
Copy link
Contributor Author

done.

@FezVrasta FezVrasta merged commit 1966b02 into FezVrasta:master May 31, 2018
@FezVrasta
Copy link
Owner

published as 2.7.1

@brianium
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants