Handle case where resizeTarget is not an event listener #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FezVrasta many thanks for this library. I've been using it with popper.js and it is 💯
I ran into an issue recently with Safari throwing errors when using this component inside of a react portal.
It seems that in this browser React stubs in a window for
contentDocument.defaultView
that is not actually an event listener. So whenResizeAware
unmounts in Safari - it throws an error complaining thatremoveEventListener
is not a function.I included a simple fix that solves my issues, and might just make things more robust in general?
Let me know if I can do anything to help get this merged 😄
Many thanks again for the work you do on these libs!