feat(action): add binary-dir input to reuse a prebuilt ferrflow - #161
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
July 15, 2026 07:01
This was referenced Jul 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160.
The
fullbenchmark ran its owncargo build --release, even though callers (FerrFlow) already build the release binary in an earlier job and upload it as an artifact — so every run paid a full release compile twice.binary-dirinput. When set, the build step is skipped and that directory goes on PATH instead; it fails loudly if the directory holds no executableferrflowrather than silently benchmarking whatever is on PATH.''keeps the current behaviour (build in-place), so existing callers are unaffected.Also refreshed two stale rows in the README input table while touching it:
warmup's documented default was3(the action defaults to2) andgroup-filterwas missing entirely.A companion FerrFlow PR wires its benchmark job to the
ferrflow-binaryartifact it already publishes.