Skip to content

feat(action): add binary-dir input to reuse a prebuilt ferrflow - #161

Merged
BryanFRD merged 2 commits into
mainfrom
feat/reuse-prebuilt-binary
Jul 15, 2026
Merged

feat(action): add binary-dir input to reuse a prebuilt ferrflow#161
BryanFRD merged 2 commits into
mainfrom
feat/reuse-prebuilt-binary

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Closes #160.

The full benchmark ran its own cargo build --release, even though callers (FerrFlow) already build the release binary in an earlier job and upload it as an artifact — so every run paid a full release compile twice.

  • New binary-dir input. When set, the build step is skipped and that directory goes on PATH instead; it fails loudly if the directory holds no executable ferrflow rather than silently benchmarking whatever is on PATH.
  • Default '' keeps the current behaviour (build in-place), so existing callers are unaffected.

Also refreshed two stale rows in the README input table while touching it: warmup's documented default was 3 (the action defaults to 2) and group-filter was missing entirely.

A companion FerrFlow PR wires its benchmark job to the ferrflow-binary artifact it already publishes.

@BryanFRD
BryanFRD enabled auto-merge (squash) July 15, 2026 07:01
Comment thread action.yml Fixed
@BryanFRD
BryanFRD merged commit eef0ec7 into main Jul 15, 2026
14 checks passed
@BryanFRD
BryanFRD deleted the feat/reuse-prebuilt-binary branch July 15, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

full benchmark rebuilds ferrflow the caller already built

2 participants