Removing file artifacts generated from tests #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurabegin
requested changes
Jun 13, 2023
| @@ -138,12 +138,6 @@ case class TestClassOutput(`a`: Option[String] = None, | |||
| Seq(TestInput(d = Seq())).toDF, | |||
| LocalDateTime.of(1900, 1, 1, 0, 0, 0)) | |||
|
|
|||
| ClassGenerator.writeCLassFile( | |||
There was a problem hiding this comment.
Je suis d'accord que ce call ne sert à rien dans la réussite du test, mais le test "class generator" should "create folder if not exists" ne vérifie pas le résultat de l'écriture. On pourrait le retirer du test de Timestamp, mais écrire un test qui vérifie que le fichier écrit par writeCLassFile est valide?
There was a problem hiding this comment.
Oui le test est pertinent en effet. Par contre on devrait deleter le fichier du repo et ajouter une entrée dans le .gitignore
| @@ -138,12 +138,6 @@ case class TestClassOutput(`a`: Option[String] = None, | |||
| Seq(TestInput(d = Seq())).toDF, | |||
| LocalDateTime.of(1900, 1, 1, 0, 0, 0)) | |||
|
|
|||
| ClassGenerator.writeCLassFile( | |||
There was a problem hiding this comment.
Effectivement, c'est un typo. À remplacer par writeClassFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La suite de test gérére présentement un fichier
TestClassOutput.scala, qui a été commit à deux endroits différents dans le code.Ce fichier est généré par
ClassGenerator.writeCLassFile(petite commentaire, doit-on dire write-C-Lass-File ou bien c'est un typo)
La fonction est présentement utilisée dans deux tests :
/target/targetJe crois qu'il est prudent de retirer le code la commit
e4b195apuisque :