Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Wrong SourcePackages location with xcodebuild from plugin context #142

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

xmanu
Copy link
Contributor

@xmanu xmanu commented Apr 2, 2025

This PR fixes a wrong --custom-packages-file-path in Xcode cloud and some local xcodebuild builds. See #141 for more details.

@FelixHerrmann FelixHerrmann changed the title Fix wrong path calculation as reported in #141 [Fix] Wrong SourcePackages location with xcodebuild from plugin context Apr 2, 2025
@xmanu
Copy link
Contributor Author

xmanu commented Apr 2, 2025

Should I fix the formatting to satisfy the linter?

@FelixHerrmann FelixHerrmann linked an issue Apr 2, 2025 that may be closed by this pull request
Copy link
Owner

@FelixHerrmann FelixHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the lint error

@FelixHerrmann FelixHerrmann merged commit 12ecc8f into FelixHerrmann:master Apr 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode cloud build fails with Version 4.7.1
2 participants